Release v1.7.4 #3472
Release v1.7.4 #3472
Conversation
bexsoft
requested review from
donatello,
harshavardhana,
pjuarezd,
ramondeklein,
reivaj05,
cesnietor,
allanrogerr,
dvaldivia,
prakashsvmx,
adriangitvitz,
bayasdev and
JoelRuizRojas
|
Do we merge with the CI failure? |
I don’t think we should. Why do we need a new console release at this time? |
Yes, This PDF issue is not a real failure, PDF is rendered correctly in the UI Locally I see an error related to pdf worker library required for this and testcafe. This needs further investigation |
bexsoft
force-pushed
the
release-v1.7.4
branch
from
0caa05e
to
1d8885e
Compare
bexsoft
force-pushed
the
release-v1.7.4
branch
from
b0d3d56
to
9033e5f
Compare
Signed-off-by: Benjamin Perez <[email protected]>
bexsoft
force-pushed
the
release-v1.7.4
branch
from
9033e5f
to
286dc98
Compare
There was a problem hiding this comment.
@bexsoft Did you regenerate the files after rebasing to the latest master? When I run make release, then all generated files are different but that may be caused due to different versions. I do think the build folder should be identical and not depend on whoever runs make release.
For that reason, I am always a fan of letting the CI/CD build the final output instead. Then it's consistent.
Yes, @ramondeklein, all files are updated with the latest master change. we use a release script to generate these files, maybe could be related |
|
@bexsoft corresponding docs ready to merge |
No description provided.